Correction of methods that were unnecessarily declared as virtual

doc/benchmark.md

@@ -4,7 +4,7 @@ Benchmark
 The Rotozoomer example can perform a benchmark run with the parameter "-b" to determine the FINAL CUT character speed in the terminal.
 
 
-[![rotozoomer-benchmark](https://asciinema.org/a/smuTNcVd7uJ9InchzXmGhDtIX.svg)](https://asciinema.org/a/smuTNcVd7uJ9InchzXmGhDtIX)
+[![rotozoomer-benchmark](https://asciinema.org/a/316531.svg)](https://asciinema.org/a/316531)
 
 
 Speed tests

examples/rotozoomer.cpp

@@ -211,7 +211,7 @@ inline finalcut::FString RotoZoomer::getReport()
 void RotoZoomer::onShow (finalcut::FShowEvent*)
 {
   if ( ! benchmark )
-    addTimer(33);
+    addTimer(33);  // Starts the timer every 33 milliseconds
   else
   {
     for (path = 1; path < loops; path++)

examples/string-operations.cpp

@@ -623,7 +623,7 @@ void indexExample()
 {
   // Test: get character access at a specified index position
   finalcut::FString index{5};  // string with five characters
-  index = "index";
+  index.setString("index");
 
   try
   {

examples/transparent.cpp

@@ -250,7 +250,7 @@ void MainWindow::onClose (finalcut::FCloseEvent* ev)
 //----------------------------------------------------------------------
 void MainWindow::onShow (finalcut::FShowEvent*)
 {
-  addTimer(100);
+  addTimer(100);  // Call onTimer() every 100 ms
 }
 
 //----------------------------------------------------------------------

examples/ui.cpp

@@ -128,7 +128,7 @@ ProgressDialog::~ProgressDialog()  // destructor
 //----------------------------------------------------------------------
 void ProgressDialog::onShow (finalcut::FShowEvent*)
 {
-  addTimer(15);
+  addTimer(15);  // Starts the timer every 15 ms
 }
 
 //----------------------------------------------------------------------

examples/watch.cpp

@@ -156,11 +156,11 @@ void Watch::cb_clock (finalcut::FWidget*, FDataPtr)
   if ( clock_sw.isChecked() )
   {
     printTime();
-    addTimer(1000);
+    addTimer(1000);  // Call onTimer() every second (1000 ms)
   }
   else
   {
-    delAllTimer();
+    delAllTimer();  // Delete all timers and stop updating the time
     time_str = "--:--:--";
     time_str.redraw();
   }

src/flistview.cpp

@@ -2738,12 +2738,11 @@ void FListView::stepBackward (int distance)
 //----------------------------------------------------------------------
 void FListView::scrollToX (int x)
 {
-  const int xoffset_end = int(max_line_width) - int(getClientWidth());
-
   if ( xoffset == x )
     return;
 
   xoffset = x;
+  const int xoffset_end = int(max_line_width) - int(getClientWidth());
 
   if ( xoffset > xoffset_end )
     xoffset = xoffset_end;

src/include/final/fcolorpalette.h

@@ -51,13 +51,13 @@ class FColorPalette final
     FColorPalette() = default;
 
     // Destructor
-    virtual ~FColorPalette();
+    ~FColorPalette();
 
     // Typedefs
     typedef void (*funcp)(FColor, int, int, int);
 
     // Accessor
-    virtual const FString getClassName() const;
+    const FString getClassName() const;
 
     // Methods
     static void set8ColorPalette (funcp);

src/include/final/fkeyboard.h

@@ -93,13 +93,13 @@ class FKeyboard final
     FKeyboard (const FKeyboard&) = delete;
 
     // Destructor
-    virtual ~FKeyboard();
+    ~FKeyboard();
 
     // Disable assignment operator (=)
     FKeyboard& operator = (const FKeyboard&) = delete;
 
     // Accessors
-    virtual const FString getClassName() const;
+    const FString         getClassName() const;
     FKey                  getKey();
     const FString         getKeyName (const FKey);
     keybuffer&            getKeyBuffer();

src/include/final/foptiattr.h

@@ -121,7 +121,7 @@ class FOptiAttr final
     FOptiAttr (const FOptiAttr&) = delete;
 
     // Destructor
-    virtual ~FOptiAttr();
+    ~FOptiAttr();
 
     // Disable assignment operator (=)
     FOptiAttr& operator = (const FOptiAttr&) = delete;

src/include/final/foptimove.h

@@ -106,7 +106,7 @@ class FOptiMove final
     explicit FOptiMove (int = 0);
 
     // Destructor
-    virtual ~FOptiMove();
+    ~FOptiMove();
 
     // Accessors
     const FString getClassName() const;

src/include/final/fstartoptions.h

@@ -58,13 +58,13 @@ class FStartOptions final
     FStartOptions (const FStartOptions&) = delete;
 
     // Destructor
-    virtual ~FStartOptions();
+    ~FStartOptions();
 
     // Disable assignment operator (=)
     FStartOptions& operator = (const FStartOptions&) = delete;
 
     // Accessors
-    virtual const FString getClassName();
+    const FString getClassName();
     static FStartOptions& getFStartOptions();
 
     // Mutator

src/include/final/fterm.h

@@ -167,13 +167,13 @@ class FTerm final
     FTerm (const FTerm&) = delete;
 
     // Destructor
-    virtual ~FTerm();
+    ~FTerm();
 
     // Disable assignment operator (=)
     FTerm& operator = (const FTerm&) = delete;
 
     // Accessors
-    virtual const FString  getClassName() const;
+    const FString          getClassName() const;
     static std::size_t     getLineNumber();
     static std::size_t     getColumnNumber();
     static const FString   getKeyName (FKey);

src/include/final/ftermcap.h

@@ -87,7 +87,7 @@ class FTermcap final
     FTermcap() = default;
 
     // Destructor
-    virtual ~FTermcap() = default;
+    ~FTermcap() = default;
 
     // Accessors
     const FString    getClassName() const;

src/include/final/ftermcapquirks.h

@@ -53,10 +53,10 @@ class FTermcapQuirks final
     FTermcapQuirks();
 
     // Destructor
-    virtual ~FTermcapQuirks();
+    ~FTermcapQuirks();
 
     // Accessor
-    virtual const FString getClassName() const;
+    const FString getClassName() const;
 
     // Methods
     static void terminalFixup();

src/include/final/ftermdetection.h

@@ -82,7 +82,7 @@ class FTermDetection final
     FTermDetection();
 
     // Destructor
-    virtual ~FTermDetection();
+    ~FTermDetection();
 
     // Accessor
     const FString         getClassName() const;

src/include/final/ftermfreebsd.h

@@ -89,7 +89,7 @@ class FTermFreeBSD final
     FTermFreeBSD (const FTermFreeBSD&) = delete;
 
     // Destructor
-    virtual ~FTermFreeBSD() = default;
+    ~FTermFreeBSD() = default;
 
     // Disable assignment operator (=)
     FTermFreeBSD& operator = (const FTermFreeBSD&) = delete;

src/include/final/ftermios.h

@@ -55,7 +55,7 @@ class FTermios final
     FTermios();
 
     // Destructor
-    virtual ~FTermios();
+    ~FTermios();
 
     // Accessors
     const FString   getClassName() const;

src/include/final/ftermlinux.h

@@ -87,7 +87,7 @@ class FTermLinux final
     FTermLinux (const FTermLinux&) = delete;
 
     // Destructor
-    virtual ~FTermLinux();
+    ~FTermLinux();
 
     // Disable assignment operator (=)
     FTermLinux& operator = (const FTermLinux&) = delete;

src/include/final/ftermopenbsd.h

@@ -81,7 +81,7 @@ class FTermOpenBSD final
     FTermOpenBSD (const FTermOpenBSD&) = delete;
 
     // Destructor
-    virtual ~FTermOpenBSD();
+    ~FTermOpenBSD();
 
     // Disable assignment operator (=)
     FTermOpenBSD& operator = (const FTermOpenBSD&) = delete;

src/include/final/ftermxterminal.h

@@ -57,7 +57,7 @@ class FTermXTerminal final
     FTermXTerminal (const FTermXTerminal&) = delete;
 
     // Destructor
-    virtual ~FTermXTerminal();
+    ~FTermXTerminal();
 
     // Disable assignment operator (=)
     FTermXTerminal& operator = (const FTermXTerminal&) = delete;

src/include/final/sgr_optimizer.h

@@ -57,7 +57,7 @@ class SGRoptimizer final
     explicit SGRoptimizer (attributebuffer&);
 
     // Destructor
-    virtual ~SGRoptimizer();
+    ~SGRoptimizer();
 
     // Disable copy constructor
     SGRoptimizer (const SGRoptimizer&) = delete;